i don't understand what the new 'stack' system for PRs on github is for.
Timeline
Post
Remote status
Replies
14
@lain there is a what now?
@lain oh no. GitHub is turning into TikTok with their short form content, but I guess this would work for very, very long code changes except at that point you might as well make the code more elegant and push in smaller batches.
@Mellivora i mean, there's already a 'smaller piece of code that you can review and merge independently', it's called 'commit'. I guess if people make bad commits, this can be alright, but just find it confusing.
@lain they'd do anything, but find a solution to stop all these slop coders from pushing their code to the point their infrastructure is having difficulty keeping up.
@lain that reminds me... I prolly need to check if that requires me to add anything new to one of my osint tools. 👀
Just doesn't make sense on paper why they'd have that?
@lain @Mellivora They couldn't copy Gitlab's Epics, which are made for that purpose, so they chose to do it the worst way possible I guess. I think it's supposed to be used like Epics for large tasks that are split independently into small PRs, so you don't review a 15K+ PR at once.
@phnt @Mellivora maybe people are just using it wrong. i see it used for like stacks of 8 PRs and each PR is ~100-150 lines.
@lain I don't use or recommend GitHub, but some of my software engineering friends complain that AI-originated pull requests are too big - and are single commits, so breaking up into individual commits doesn't help. Maybe this is meant to address that somehow.
@mattskala okay but you can just tell the AI to make smaller commits...
@lain Well, it ain't me...
@lain @phnt @Mellivora my understanding is that it's something like this
"hey I have this big idea and it's gonna be a lot of changes, but I can't do it all at once. So I have to do it in pieces. First, I'll open the PR that does the core changes. But instead of waiting for them to review before proceeding -- which could take forever -- I'll open another PR against that PR and start adding the next round of changes there..."
repeat until you're done. Then if PR 1 needs refactoring, you do it, then fix PR 2 which now won't merge cleanly, etc etc
It feels to me like this is more of a "corporate software development hellscape momentum hack" than anything useful for open source communities
"hey I have this big idea and it's gonna be a lot of changes, but I can't do it all at once. So I have to do it in pieces. First, I'll open the PR that does the core changes. But instead of waiting for them to review before proceeding -- which could take forever -- I'll open another PR against that PR and start adding the next round of changes there..."
repeat until you're done. Then if PR 1 needs refactoring, you do it, then fix PR 2 which now won't merge cleanly, etc etc
It feels to me like this is more of a "corporate software development hellscape momentum hack" than anything useful for open source communities
@feld @Mellivora @lain Yeah, so basically Gitlab Epics. But instead of linking issues to a giant feature/task tracking one, it links PRs instead.
@phnt @Mellivora @lain I don't know what the Epics are but Gitlab already supported stacked PRs too
Epics are probably just a better way to organize them
Epics are probably just a better way to organize them